feat: add VLLMRanker#3174
Merged
Merged
Conversation
github-actions
Bot
added
topic:CI
integration:vllm
type:documentation
Contributor
Coverage report (vllm)
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
anakin87
requested review from
bogdankostic and
davidsbatista
and removed request for
a team and
davidsbatista
bogdankostic
approved these changes
Apr 17, 2026
Contributor
bogdankostic
left a comment
bogdankostic
left a comment
There was a problem hiding this comment.
Looking good overall, I just have one minor nit regrading the readability of a return statement.
|
|
||
| def test_parse_response_raises_on_error(self): | ||
| with pytest.raises(RuntimeError, match="boom"): | ||
| VLLMRanker._parse_response({"detail": "boom"}, [], score_threshold=None) |
…/vllm/ranker.py Co-authored-by: bogdankostic <bogdankostic@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
/v1/rerankendpoint: we call it withhttpx(differently from other components; this is not part of the OpenAI standard)How did you test it?
New unit and integration tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.